added options.noShadow #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. The PR has no errors, and all tests pass. Don't know why, but sometimes when installing the NPM deps (usually when downloading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new feature: avoid use of visual aid shadow through
options.noShadow.This feature is specially useful when the target is
svgorcanvas, where you want to draw a new element instead of inserting it before/after a node under the parent.The PR avoids all the DOM insertions/deletions related to the shadow processing, improving the performance of
dragula. ThedropJavaScript event is passed as parameter to thedropevent. This way the user can place/draw the new element at the exact coordinates of dropping.